Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammatical update #8197

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@Furchin
Copy link
Contributor

commented Aug 22, 2019

Problem

You're create a jvm_app target definition for bundling a Scala or Java project and you want to include assets such as config files or shell scripts in the bundle.

"You're create" is a contraction of "You are create", which is not proper English grammar; "You want to create" or "You have created" or "You're creating" would all work as well.

Solution

Changed grammatical structure.

Result

No behavioral change; this affects the docs only.

Minor grammatical update
>You're create a jvm_app target definition for bundling a Scala or Java project and you want to include assets such as config files or shell scripts in the bundle.

"You are create" is not proper English grammar; "You want to create" or "You have created" or "You're creating" would all work as well.
@stuhood
Copy link
Member

left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Always risky, but I don't see any rst/md errors here, so will save the CI time.

@stuhood stuhood merged commit c7dee66 into pantsbuild:master Aug 22, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.