Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth logic out of RunTracker and into BasicAuth #8211

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@asherf
Copy link
Contributor

commented Aug 26, 2019

Planning to add more way to auth to the remote server (using an access token)
So this is a first step in refactoring the logic out of RunTrack so there is a proper abstraction here.

Problem

Currently, there is only one way to auth with the remote server (for run tracker)
This makes scenarios where we want to send data to remote server from CI harder.

Solution

I am working on adding support for using Bearer Token to authenticate from the server (the token can be provided via an environment variable in CI)
This is a small refactor to create a cleaner seperation of concerns so the logic in RunTracker is not aware of how it authenticates with the remote server.

Result

This code doesn't change existing behavior (note the change in dependencies).

@asherf asherf force-pushed the asherf:runtracker branch 4 times, most recently from f1571bd to e2b5051 Aug 26, 2019

@asherf asherf force-pushed the asherf:runtracker branch 2 times, most recently from 1d94d5b to de6d4cc Aug 29, 2019

Refactor auth logic out of RunTracker and into BasicAuth
Planning to add more way to auth to the remote server (using an access token)
So this is a first step in refactoring the logic out of RunTrack so there is a proper abstraction here.

@asherf asherf force-pushed the asherf:runtracker branch from de6d4cc to 557dae7 Aug 31, 2019

@Eric-Arellano Eric-Arellano merged commit 21d0011 into pantsbuild:master Sep 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asherf asherf deleted the asherf:runtracker branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.