Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pchevalier/local execution server #8213

Merged

Conversation

@pierrechevalier83
Copy link
Contributor

commented Aug 27, 2019

Problem

To test pants behaviour on remoting, the current practice consists of creating a ssh tunnel to one of the execution servers or running a local scoot server. This creates a barrier to quickly testing one's changes.

Solution

Create a local_execution_server executable that leverages the mock execution server library.

Result

This allows us to run an execution server on localhost that will expect exactly one request (described through CLI arguments) and react to it with a default operation.
We may want to enrich what this local_execution_server can do in the future (such as handle multiple requests), but only do the minimum needed at the moment. The CLI application can always be extended later on a per-need basis.

@pierrechevalier83

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Note: this is a subset from #8166. I am aiming to make that PR more lightweight as I keep troubleshooting the travis issues over there.

@hrfuller
Copy link
Contributor

left a comment

Thanks, LGTM

@blorente blorente merged commit cf74d6b into pantsbuild:master Aug 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.