Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a header `X-B3-Flags: 1` to the request to Zipkin server #8223

Conversation

@cattibrie
Copy link
Contributor

commented Aug 29, 2019

Add a header X-B3-Flags: 1 to the request to Zipkin server. It is a debug flag that ensures that the trace will be retained on the server side.
The decision to sample is made on the client side by setting --reporting-zipkin-sample-rate.

@illicitonion
Copy link
Contributor

left a comment

Thanks!

@stuhood stuhood added this to the 1.19.x milestone Aug 29, 2019

@@ -49,6 +49,7 @@ def send(self, payload):
args = ['curl', '-v',
'-X', 'POST',
'-H', 'Content-Type: application/json',
'-H', 'X-B3-Flags: 1',

This comment has been minimized.

Copy link
@stuhood

stuhood Aug 29, 2019

Member

This should probably have a comment that includes some of the PR description in order to make things easier for the reader. It's not a particularly self-explanatory flag.

@pierrechevalier83
Copy link
Contributor

left a comment

Looks good to me (and I agree with Stu that a comment would be helpful 😄)

@illicitonion illicitonion merged commit d4b35b9 into pantsbuild:master Aug 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.