Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when uploading stats to stats storage #8233

Conversation

@cattibrie
Copy link
Contributor

commented Sep 2, 2019

Problem

Stats are not uploaded to stats storage because the size of the request is too big.

Workunit information from the engine is passed to python as a part of the metrics and are recorded as a part of pantsd_stats.

Solution

Workunit info from the engine is not passed to pantsd_stats.

@illicitonion illicitonion self-requested a review Sep 2, 2019

@illicitonion
Copy link
Contributor

left a comment

Looks great, thanks!

Could you modify RunTrackerIntegrationTest to verify that the workunits don't show up in there?

@illicitonion illicitonion merged commit 85f60cf into pantsbuild:master Sep 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
blorente added a commit that referenced this pull request Sep 4, 2019
Fix error when uploading stats to stats storage (#8233)
### Problem
Stats are not uploaded to stats storage because the size of the request is too big.

Workunit information from the engine is passed to python as a part of the metrics and are recorded as a part of pantsd_stats.

### Solution
Workunit info from the engine is not passed to pantsd_stats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.