Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct function on list #8238

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@illicitonion
Copy link
Contributor

commented Sep 4, 2019

At some point I guess we should add a test covering this code? I managed
to trigger it!

Use correct function on list
At some point I guess we should add a test covering this code? I managed
to trigger it!

@illicitonion illicitonion requested review from cosmicexplorer and blorente Sep 4, 2019

@blorente
Copy link
Contributor

left a comment

I agree that we should exercise this code, but wonder how much of it will change when we make pantsd the only way to run pants, and large chunks of LocalPantsRunner go away.

Actually, that might be a point in favour of adding additional testing.

@illicitonion illicitonion merged commit 9c3994b into pantsbuild:master Sep 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/appendnotpush branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.