Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quash warnings about missing dyn in generated code #8245

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@illicitonion
Copy link
Contributor

commented Sep 5, 2019

At some point we'll update to a newer code generator, or we'd switch to
tower, but until then...

Quash warnings about missing dyn in generated code
At some point we'll update to a newer code generator, or we'd switch to
tower, but until then...

@illicitonion illicitonion requested a review from ity Sep 5, 2019

@stuhood
stuhood approved these changes Sep 5, 2019
Copy link
Member

left a comment

Hah, nice. I attempted to update some things while doing the rust update, but gave up. Is it worth pointing to a "tower" ticket?

Thanks!

@ity
ity approved these changes Sep 6, 2019

@illicitonion illicitonion merged commit 0aa66d1 into pantsbuild:master Sep 6, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/dynwarnings branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.