Deprecate @rule(...) in favor of @rule
#8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Sep 29, 2019
| empty_value=inspect.Signature.empty, | ||
| raise_type=MissingReturnTypeAnnotation | ||
|
|
||
| if len(args) != 1 and not inspect.isfunction(args[0]): |
There was a problem hiding this comment.
I know you like this style. In this case though you're thrashing code just laid down. Did I violate a style guide? If so - all good. If not, seems worth establishing this there or thinking 2x before doing it.
There was a problem hiding this comment.
No, looks like our style guide is silent on this style of early returns / inverted conditionals: https://www.pantsbuild.org/styleguide.html
Noted for the future about not whimsically changing it. Lmk if you'd like me to change back here - happy to.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #8338.