Replace most usages of datatype() with @dataclass #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
force-pushed
the
no-more-datatype
branch
2 times, most recently
from
6ad0c41
to
760bb6b
Compare
Eric-Arellano
force-pushed
the
no-more-datatype
branch
from
760bb6b
to
c6e65dc
Compare
Eric-Arellano
requested review from
cosmicexplorer,
gshuflin,
stuhood and
jsirois
and removed request for
cosmicexplorer
|
This is hot!! But doesn't it require #8181 to be merged? |
Nope! Confirmed with @cosmicexplorer that we can merge this before! #8181 adds a check to ensure that we don't forget to set |
benjyw
approved these changes
Sep 30, 2019
Eric-Arellano
added a commit
that referenced
this pull request
Oct 10, 2019
Builds off of #8362, this time tackling trickier instances. This introduces a new idiom of using `@dataclass(unsafe_hash=True)`. Certain custom `__new__` implementations could not be implemented using either the normal dataclass auto-generated `__init__()` nor through `__post_init__()`. When `frozen=True`, it is impossible to implement your own `__init__()` because you cannot set attribute values. So, we cannot use `frozen=True` but still must have a hash to work with V2. `unsafe_hash=True` does this for us. We use `@frozen_after_init` from #8431 to ensure that we don't accidentally mutate the object after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8181 demonstrated that it's possible to use
@dataclass(frozen=True)as an alternative todatatype(). As argued there, this brings several benefits, including aligning us more to the stdlib and allowing MyPy to understand our code for free.This PR takes a first pass to convert >75% of
datatypeusages to@dataclass. It naively does this translation:datatypes()that inherit normal classes with class variables, which would get overriddendatatypes()with custom__new__()that is not easily replicated