Skip flaky PytestRunTimeoutIntegrationTest test. #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_pytest_run_killed_by_signal in particular is flaky: pantsbuild#9441. # Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # No Rust changes made. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made. # Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # No Rust changes made. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
Eric-Arellano
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Do you expect this to be flaky because the timeout is too low or because sometimes the kill never actually happens? If the former, we could bump the timeout from 100 to 120.
That sounds crazy for a simple test to take 100 seconds, though, so I suspect the latter.
I didn't actually stop to consider. I'm still in slash and burn mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_pytest_run_killed_by_signal in particular is flaky: #9441.
[ci skip-rust-tests]
[ci skip-jvm-tests]