Fix Target API bindings not loading for plugins #9788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
stuhood
approved these changes
May 15, 2020
|
|
||
| setup_py.setup_py_keywords["entry_points"] = entry_points | ||
| setup_py.setup_py_keywords["entry_points"] = {"pantsbuild.plugin": entry_points} |
There was a problem hiding this comment.
Is this something that setup_py was consuming under this name, or is it only for our consumption?
There was a problem hiding this comment.
I'm not sure - this is the same as before, just now inlined.
Eric-Arellano
added a commit
that referenced
this pull request
May 15, 2020
With a plugin, we must explicitly set the `entry_point` in the distribution's metadata. [ci skip-rust-tests] [ci skip-jvm-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a plugin, we must explicitly set the
entry_pointin the distribution's metadata.[ci skip-rust-tests]
[ci skip-jvm-tests]