Error eagerly if an interpreter binary doesn't exist. #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception class already existed, it just wasn't used. Due to caching, the interpreter may or may not fail in find_binary(), so the calling code might fail at some later stage. This change causes us to fail eagerly and consistently if the binary doesn't exist on disk.
|
Fixes #672 |
Eric-Arellano
approved these changes
Feb 12, 2020
Eric-Arellano
approved these changes
Feb 12, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception class already existed, it just wasn't used.
Due to caching, the interpreter may or may not fail
in find_binary(), so the calling code might fail at some
later stage.
This change causes us to fail eagerly and consistently if
the binary doesn't exist on disk.