Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Stormed doesn't work with RabbitMQ 2.4.1 #6

Closed
jacobk opened this Issue · 4 comments

3 participants

@jacobk

Stormed doesn't support all field types when parsing field-tables.

RabbitMQ 2.4.1 have boolean- and fieldtable-types in the server­-properties table parameter sent in the connetion.start method.

Stormed only seems to support fields of typ short/long-string.

Traceback (most recent call last):
  File "/Users/jacob/.envs/stormed_debug/lib/python2.7/site-packages/tornado/iostream.py", line 230, in _run_callback
    callback(*args, **kwargs)
  File "/Users/jacob/.envs/stormed_debug/lib/python2.7/site-packages/tornado/stack_context.py", line 173, in wrapped
    callback(*args, **kwargs)
  File "/Users/jacob/Development/slum/stormed_debug/stormed-amqp/stormed/frame.py", line 40, in _with_payload
    self.frame.set_payload(payload)
  File "/Users/jacob/Development/slum/stormed_debug/stormed-amqp/stormed/frame.py", line 56, in set_payload
    self.payload = parse_method(payload)
  File "/Users/jacob/Development/slum/stormed_debug/stormed-amqp/stormed/serialization.py", line 58, in parse_method
    vals = parse_fields(types, data[4:])
  File "/Users/jacob/Development/slum/stormed_debug/stormed-amqp/stormed/serialization.py", line 21, in parse_fields
    val, offset = parser(data, offset)
  File "/Users/jacob/Development/slum/stormed_debug/stormed-amqp/stormed/serialization.py", line 187, in parse_table
    assert typ in field_type_dict, typ
AssertionError: F
@paolo-losi
Owner

Hi Jacob,

thanks for the report. It should be fixed now (all tests passes with rabbitmq 2.4.1).

Is it ok for you to checkout master?

@jacobk

(that was quick)
Seems to work fine!

Thanks!

@paolo-losi
Owner

The fix was easy :-)

Thank you very much for the report. Keep me posted for any issue...

@brandon-rhodes

Is there likely to be a stormed-amqp release in the near future with this bugfix? The entry on PyPI still seems to point at 0.1 which was released back in January, before this fix landed (assuming that I am looking at the most recent version and not an old PyPI entry).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.