Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Logging configuration & tutorial 6 #8
Thanks! I've tested it againt tornado 1.2 and everything works as expected. Which tornado version have you tested?
There a couple of small typos and a couple of pep8 warnings:
Do you want to take care of those or me to do that?
I tested it against Tornado 1.2.1.
I have some other things to do today, so you can edit the files to fit your preferred style. I tried to adhere to your general style and PEP08, but it looks like I missed those few minor things. The blank lines with whitespace are within a class (and I used a class to make it more like the original Pika example), which is consistent with how I usually use whitespace on blank lines inside indented code blocks (I match the indentation until the end of the block, in this case the class). I actually didn't know that was part of PEP08, which I have read several times.
Anyway, if there's anything you don't like about these files, feel free to change them.