Logging configuration & tutorial 6 #8

Merged
merged 4 commits into from Jul 15, 2011

Conversation

Projects
None yet
2 participants
@brimcfadden
Contributor

brimcfadden commented Jul 15, 2011

I'm issuing a new pull request to avoid stacking the new commits on top of the old one.

@paolo-losi

This comment has been minimized.

Show comment
Hide comment
@paolo-losi

paolo-losi Jul 15, 2011

small typo: it should be quue='rpc_queue'

small typo: it should be quue='rpc_queue'

This comment has been minimized.

Show comment
Hide comment
@brimcfadden

brimcfadden Jul 15, 2011

Owner

Whoops. This must have gotten copied from something else.

Owner

brimcfadden replied Jul 15, 2011

Whoops. This must have gotten copied from something else.

@paolo-losi

This comment has been minimized.

Show comment
Hide comment
@paolo-losi

paolo-losi Jul 15, 2011

Owner

Thanks! I've tested it againt tornado 1.2 and everything works as expected. Which tornado version have you tested?
(my question is totally unrelated with your pull request but I haven't had the chance to test tornado 2.0 yet)

There a couple of small typos and a couple of pep8 warnings:

$ pep8 *
rpc_client.py:9:1: E302 expected 2 blank lines, found 1
rpc_client.py:14:1: W293 blank line contains whitespace
rpc_server.py:13:21: E225 missing whitespace around operator

Do you want to take care of those or me to do that?

Owner

paolo-losi commented Jul 15, 2011

Thanks! I've tested it againt tornado 1.2 and everything works as expected. Which tornado version have you tested?
(my question is totally unrelated with your pull request but I haven't had the chance to test tornado 2.0 yet)

There a couple of small typos and a couple of pep8 warnings:

$ pep8 *
rpc_client.py:9:1: E302 expected 2 blank lines, found 1
rpc_client.py:14:1: W293 blank line contains whitespace
rpc_server.py:13:21: E225 missing whitespace around operator

Do you want to take care of those or me to do that?

@brimcfadden

This comment has been minimized.

Show comment
Hide comment
@brimcfadden

brimcfadden Jul 15, 2011

Contributor

I tested it against Tornado 1.2.1.

I have some other things to do today, so you can edit the files to fit your preferred style. I tried to adhere to your general style and PEP08, but it looks like I missed those few minor things. The blank lines with whitespace are within a class (and I used a class to make it more like the original Pika example), which is consistent with how I usually use whitespace on blank lines inside indented code blocks (I match the indentation until the end of the block, in this case the class). I actually didn't know that was part of PEP08, which I have read several times.

Anyway, if there's anything you don't like about these files, feel free to change them.

Contributor

brimcfadden commented Jul 15, 2011

I tested it against Tornado 1.2.1.

I have some other things to do today, so you can edit the files to fit your preferred style. I tried to adhere to your general style and PEP08, but it looks like I missed those few minor things. The blank lines with whitespace are within a class (and I used a class to make it more like the original Pika example), which is consistent with how I usually use whitespace on blank lines inside indented code blocks (I match the indentation until the end of the block, in this case the class). I actually didn't know that was part of PEP08, which I have read several times.

Anyway, if there's anything you don't like about these files, feel free to change them.

@paolo-losi

This comment has been minimized.

Show comment
Hide comment
@paolo-losi

paolo-losi Jul 15, 2011

Owner

Brian,

thanks again. I'm merging it...

Owner

paolo-losi commented Jul 15, 2011

Brian,

thanks again. I'm merging it...

paolo-losi added a commit that referenced this pull request Jul 15, 2011

Merge pull request #8 from brimcfadden/master
Logging configuration & tutorial 6

@paolo-losi paolo-losi merged commit da4889b into paolo-losi:master Jul 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment