The "inside" function does not work as it should.

[OpenUAS]

The "inside" function does not work as it should. It does in v4.2.2 but not in v5.0 and 5.1_dev

It is a crucial function IMHO and should be on top of the issue list. I nearly lost aircraft because of this, actually I did notice some weird behavior but thought it was some other mistake I've made myself in my flightplan exceptions.

Step to Reproduce:

Run default microjet with flightplan versatile, launch it, let it take off to standby, the click on flightplan "Stay inside Square"
In v4.2 correct behavior, in v5.x not flips back an forth go WP1 an is inside.

I've also tested with all own flightplans using this function, same issue.

CORRECT:

INCORRECT:

The generated code however is the same!

v4.2.2

static inline bool_t InsideSquare(float _x, float _y) {
if (_y <= 200.0) {
if (_y <= 0.0) {
return FALSE;
} else {
return (-100.0<= _x && _x <= 100.0);
}
} else {
return FALSE;
}
}

v5.1_dev_xyz

static inline bool_t InsideSquare(float _x, float _y) {
if (_y <= 200.0) {
if (_y <= 0.0) {
return FALSE;
} else {
return (-100.0<= _x && _x <= 100.0);
}
} else {
return FALSE;
}
}

[OpenUAS]

You are the PPRZ Hero of the day, thanks for the fix, really appreciated.