-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[module] driver for the TeraRanger One range finder #1888
Conversation
<configure name="TERARANGER_ONE_I2C_DEV" value="i2cX" description="Select I2C bus"/> | ||
<define name="TERARANGER_ONE_I2C_ADDR" value="0x30" description="Select an alternate I2C address"/> | ||
<define name="TERARANGER_ONE_OFFSET" value="0.0" description="Add an offset to the measurments" unit="m"/> | ||
<define name="USE_TERARANGER_ONE_AGL" value="TRUE|FALSE" description="Send data as AGL measurments to the system"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it even make sense to be able to turn this off? If yes, should probably be mentioned that it is TRUE by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the case where you don't want to use the sensor to detect ground but something else, like obstacle in front of you. In this case you don't want to send the ABI AGL message.
<module name="teraranger_one" dir="range_finder"> | ||
<doc> | ||
<description>Driver for the TeraRanger One range finder (I2C)</description> | ||
<configure name="TERARANGER_ONE_I2C_DEV" value="i2cX" description="Select I2C bus"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably mention that i2c2 is the default...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
uint16_t raw; ///< raw distance in mm | ||
float dist; ///< scaled distance in m | ||
float offset; ///< offset in m | ||
bool data_available; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't seem to be read anywhere, is this still supposed to be used somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used when you don't use the sensor through ABI message but with direct reading (see remark above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.