[module] driver for the TeraRanger One range finder #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flixr
reviewed
Oct 4, 2016
| <configure name="TERARANGER_ONE_I2C_DEV" value="i2cX" description="Select I2C bus"/> | ||
| <define name="TERARANGER_ONE_I2C_ADDR" value="0x30" description="Select an alternate I2C address"/> | ||
| <define name="TERARANGER_ONE_OFFSET" value="0.0" description="Add an offset to the measurments" unit="m"/> | ||
| <define name="USE_TERARANGER_ONE_AGL" value="TRUE|FALSE" description="Send data as AGL measurments to the system"/> |
There was a problem hiding this comment.
Does it even make sense to be able to turn this off? If yes, should probably be mentioned that it is TRUE by default.
There was a problem hiding this comment.
This is for the case where you don't want to use the sensor to detect ground but something else, like obstacle in front of you. In this case you don't want to send the ABI AGL message.
| <module name="teraranger_one" dir="range_finder"> | ||
| <doc> | ||
| <description>Driver for the TeraRanger One range finder (I2C)</description> | ||
| <configure name="TERARANGER_ONE_I2C_DEV" value="i2cX" description="Select I2C bus"/> |
There was a problem hiding this comment.
Should probably mention that i2c2 is the default...
| uint16_t raw; ///< raw distance in mm | ||
| float dist; ///< scaled distance in m | ||
| float offset; ///< offset in m | ||
| bool data_available; |
There was a problem hiding this comment.
doesn't seem to be read anywhere, is this still supposed to be used somewhere?
There was a problem hiding this comment.
This is used when you don't use the sensor through ABI message but with direct reading (see remark above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.