-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[board] add support for Parrot Disco plane #1992
Conversation
- mostly based on Bebop2 - add PWM output and SBUS input on Linux (based on ArduPilot work) - some changes to the Linux serial port lib to handle arbitrary baudrate (this code could be improved and factorized in the future) - all sensors are working, the video system is not tested
Looks good to me |
return ret; | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats up with this commented out code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original code had getter functions for the different parameters (by reading values in the system files). I commented this part to remove an unused warning and forgot it. If you think it is not useful for future improvements (checking status) I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I would rather use a pragma to silence the warning and keep the code there...
done |
- mostly based on Bebop2 - add PWM output and SBUS input on Linux (based on ArduPilot work) - some changes to the Linux serial port lib to handle arbitrary baudrate (this code could be improved and factorized in the future) - all sensors are working, the video system is not tested
(this code could be improved and factorized in the future)