[board] add support for Parrot Disco plane #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mostly based on Bebop2 - add PWM output and SBUS input on Linux (based on ArduPilot work) - some changes to the Linux serial port lib to handle arbitrary baudrate (this code could be improved and factorized in the future) - all sensors are working, the video system is not tested
|
Looks good to me |
fvantienen
approved these changes
Jan 28, 2017
flixr
reviewed
Jan 28, 2017
| return ret; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
whats up with this commented out code?
There was a problem hiding this comment.
original code had getter functions for the different parameters (by reading values in the system files). I commented this part to remove an unused warning and forgot it. If you think it is not useful for future improvements (checking status) I can remove it.
There was a problem hiding this comment.
Then I would rather use a pragma to silence the warning and keep the code there...
|
done |
podhrmic
pushed a commit
that referenced
this pull request
Mar 7, 2017
- mostly based on Bebop2 - add PWM output and SBUS input on Linux (based on ArduPilot work) - some changes to the Linux serial port lib to handle arbitrary baudrate (this code could be improved and factorized in the future) - all sensors are working, the video system is not tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this code could be improved and factorized in the future)