-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARDrone vision fix #2215
ARDrone vision fix #2215
Conversation
@@ -37,6 +37,9 @@ | |||
<module name="pose_history"/> | |||
<module name="cv_opticflow"> | |||
<define name="OPTICFLOW_CAMERA" value="bottom_camera"/> | |||
<!-- ARDrone2 FPS improvements --> | |||
<define name="OPTICFLOW_PYRAMID_LEVEL" value="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra tab here in all updated files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, fix code style is not for xml facepalm
Is this flight tested? |
Yes, I wanted to know whether it was just a number increasing or actually returning performance. Luckily it added the performance back to normal levels. |
* Test fix * added fix to other ardrone airframes using vision * removed tabs
The ARDrone in paparazzi Master was flying at 2-5 FPS, which is insufficient for proper optical flow.
Upon investigating it turns out that this is the case since #2079
where the feature management was introduced, later fixed in #2087. However the feature management is turned off by default.
Furthermore the pyramid was set two 2 layers standard.
Testing on an ARDrone and Bebop alongsides showed that the Bebop had no issue with the code and was still flying arround 90 FPS(camera maximum) while the ARDrone dropped from 30-60 FPS(camera max) to 2-5 FPS.
In this pullrequest I set the pyramid back to 0, which improved FPS to about 10-15 FPS. I also tried to turn on feature management, which had the same result. Combining these two changes returned the FPS to 30-60 FPS for an ARDrone.
I changed the setting in all ARDrone conf files that include the vision, to leave Bebop untouched.