Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] bungee_takeoff was not turning motor on #2465

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

gautierhattenberger
Copy link
Member

Two issues:

  • launch variable was not set to true which prevents the control to set throttle command
  • the autopilot_set_kill_throttle had not effects on fixedwing (in fact always setting to true). We probably missed this because this function is mostly called to kill but not to resurrect motor...

Second point is a major bug I think...

Two issues:
- launch variable was not set to true which prevents the control to set
  throttle commad
- the autopilot_set_kill_throttle had not effects on fixedwing (in fact
  allows setting to true). We probably missed this because this function
  is mostly called to kill but not to resurect motor...
Copy link
Member

@noether noether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@noether noether merged commit 2ff7410 into master Oct 10, 2019
@gautierhattenberger gautierhattenberger deleted the bungee_takeoff-fix branch October 10, 2019 19:39
@OpenUAS
Copy link
Contributor

OpenUAS commented Oct 31, 2019

A autopilot.launch=1 could also have been set in the flightplan... ( <var="autopilot.launch" set value="1" /> ) . Now we lose a bit of control since the module sets it, which is a bit more risky in case the launch fails. Btw autopilot_set_kill_throttle only set it to idle on gas engines ;) Anyhow none cares likely except me no one uses it. If it bothers in the future I'll make an improved PR...

@gautierhattenberger
Copy link
Member Author

We actually had launch failures because launch was not set.
Also I don't agree that setting from the flight plan is the same. If you set before calling the run function, it means you are waiting with the launch variable already set to true, and if you set it after, the motor won't start when requested and the procedure is likely to fail. With this solution, launch is set to true right when you need it, not before, and you will not forget to do it in the FP or by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants