Added RTCM moving baseline messages and extended amount of GPS channels #2477
Conversation
| case 1077: s->msg_type = RTCM3_MSG_1077; break; | ||
| case 1087: s->msg_type = RTCM3_MSG_1087; break; | ||
| default : printf("Unknown message type\n"); return RTCM_OK_CALLBACK_UNDEFINED; | ||
| case 1230: s->msg_type = RTCM3_MSG_1230; break; | ||
| default : printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12)); return RTCM_OK_CALLBACK_UNDEFINED; |
There was a problem hiding this comment.
This printfshould be protected with DEBUG_PRINT_PACKAGE like the others. It was not the case, but better make it right now and prevent a print on system that might not support it.
There was a problem hiding this comment.
Yes, I agree. I added the changes.
There was a problem hiding this comment.
Sorry to be annoying, but only the print should be protected, the default case with return code is still needed. It should be something like:
default:
#ifdef DEBUG_PRINT_PACKAGE
printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12));
#endif
return RTCM_OK_CALLBACK_UNDEFINED;
As a side note, when creating pull-requests you can allow maintainers to make direct code suggestions (instead of simple comment) to make little changes like this one easier: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork
There was a problem hiding this comment.
Oh sure, I overlooked that yesterday. I just added the changes (and edits from maintainers are enabled as well now).
And thank you for the info, still have to get used to git.
OpenUAS
added
Enhancement
| case 1077: s->msg_type = RTCM3_MSG_1077; break; | ||
| case 1087: s->msg_type = RTCM3_MSG_1087; break; | ||
| default : printf("Unknown message type\n"); return RTCM_OK_CALLBACK_UNDEFINED; | ||
| case 1230: s->msg_type = RTCM3_MSG_1230; break; | ||
| default : printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12)); return RTCM_OK_CALLBACK_UNDEFINED; |
There was a problem hiding this comment.
Sorry to be annoying, but only the print should be protected, the default case with return code is still needed. It should be something like:
default:
#ifdef DEBUG_PRINT_PACKAGE
printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12));
#endif
return RTCM_OK_CALLBACK_UNDEFINED;
As a side note, when creating pull-requests you can allow maintainers to make direct code suggestions (instead of simple comment) to make little changes like this one easier: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork
| #ifdef DEBUG_PRINT_PACKAGE | ||
| default : printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12)); | ||
| #endif | ||
| return RTCM_OK_CALLBACK_UNDEFINED; |
There was a problem hiding this comment.
| #ifdef DEBUG_PRINT_PACKAGE | |
| default : printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12)); | |
| #endif | |
| return RTCM_OK_CALLBACK_UNDEFINED; | |
| default: | |
| #ifdef DEBUG_PRINT_PACKAGE | |
| printf("Unknown message type %u\n", RTCMgetbitu(s->msg_buff, 24 + 0, 12)); | |
| #endif | |
| return RTCM_OK_CALLBACK_UNDEFINED; |
No description provided.