Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flight plans #2740

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

Fabien-B
Copy link
Contributor

Remove most of the illegal characters in flight plans.

Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the deref operator -> ? It is possible to use the keyword @DEREF, but in many cases, it is probably even better to use the macros like GetPosX.

@Fabien-B
Copy link
Contributor Author

I Replaced it for most cases I think.
What it seen very often is stateGetPositionEnu_f()->z.
The closest macro I found is for rotorcrafts: #define GetPosAlt() (stateGetPositionEnu_f()->z+state.ned_origin_f.hmsl).
Should these occurrences be replaced by this macro ? Won't it change the behavior ? What is state.ned_origin_f.hmsl ?

@gautierhattenberger
Copy link
Member

gautierhattenberger commented Jun 16, 2021

It is a bad way to have the reference altitude, aka ground alt. So it is probably a good idea to add a macro GetPosHeight that just returns stateGetPositionEnu_f()->z

@Fabien-B
Copy link
Contributor Author

I agree, I did that.

@gautierhattenberger gautierhattenberger merged commit 87a0526 into paparazzi:master Jun 28, 2021
@Fabien-B Fabien-B deleted the fix_flight_plans branch June 28, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants