-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition to system identification modules #2810
addition to system identification modules #2810
Conversation
|
||
#include "sys_id_chirp.h" | ||
#include "pprz_chirp.h" | ||
|
||
#include "modules/datalink/telemetry.h" | ||
#include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no subsystems folder anymore on master branch
#ifndef CHIRP_EXPONENTIAL | ||
#define CHIRP_EXPONENTIAL TRUE | ||
#endif | ||
// #ifndef CHIRP_EXPONENTIAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove if not used anymore
#include "sys_id_doublet.h" | ||
#include "pprz_doublet.h" | ||
|
||
#include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change path to modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "subsystems/datalink/telemetry.h" | |
#include "modules/datalink/telemetry.h" |
|
||
#include "sys_id_wave.h" | ||
|
||
#include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change path to modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "subsystems/datalink/telemetry.h" | |
#include "modules/datalink/telemetry.h" |
@Rollervi97 it is almost ready to merge, you still need to update the modules path that have changed in latest master branch |
@@ -28,15 +28,15 @@ | |||
#include "sys_id_chirp.h" | |||
#include "pprz_chirp.h" | |||
|
|||
#include "modules/datalink/telemetry.h" | |||
#include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "subsystems/datalink/telemetry.h" | |
#include "modules/datalink/telemetry.h" |
|
||
#ifndef SYS_ID_WAVE_H | ||
#define SYS_ID_WAVE_H | ||
#endif // SYS_ID_WAVE_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a the end of the header
@Rollervi97 update ? |
Sorry for the late reply, in this third push there should be all the modification requested. |
Fixed issue on chirp input (integration of chirp signal when noise was not present). Modification of chirp input telemetry message structure (now it includes also the current chirp input value). Addition of two new system identification input signal: doublet and wave.