addition to system identification modules #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautierhattenberger
requested changes
Dec 14, 2021
|
|
||
| #include "sys_id_chirp.h" | ||
| #include "pprz_chirp.h" | ||
|
|
||
| #include "modules/datalink/telemetry.h" | ||
| #include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
there is no subsystems folder anymore on master branch
| #ifndef CHIRP_EXPONENTIAL | ||
| #define CHIRP_EXPONENTIAL TRUE | ||
| #endif | ||
| // #ifndef CHIRP_EXPONENTIAL |
There was a problem hiding this comment.
remove if not used anymore
| #include "sys_id_doublet.h" | ||
| #include "pprz_doublet.h" | ||
|
|
||
| #include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
change path to modules
There was a problem hiding this comment.
Suggested change
| #include "subsystems/datalink/telemetry.h" | |
| #include "modules/datalink/telemetry.h" |
|
|
||
| #include "sys_id_wave.h" | ||
|
|
||
| #include "subsystems/datalink/telemetry.h" |
There was a problem hiding this comment.
change path to modules
There was a problem hiding this comment.
Suggested change
| #include "subsystems/datalink/telemetry.h" | |
| #include "modules/datalink/telemetry.h" |
gautierhattenberger
added
Airborne
Enhancement
|
@Rollervi97 it is almost ready to merge, you still need to update the modules path that have changed in latest master branch |
| @@ -28,15 +28,15 @@ | |||
| #include "sys_id_chirp.h" | |||
| #include "pprz_chirp.h" | |||
|
|
|||
| #include "modules/datalink/telemetry.h" | |||
| #include "subsystems/datalink/telemetry.h" | |||
There was a problem hiding this comment.
Suggested change
| #include "subsystems/datalink/telemetry.h" | |
| #include "modules/datalink/telemetry.h" |
gautierhattenberger
requested changes
Jan 3, 2022
|
|
||
| #ifndef SYS_ID_WAVE_H | ||
| #define SYS_ID_WAVE_H | ||
| #endif // SYS_ID_WAVE_H |
There was a problem hiding this comment.
This should be a the end of the header
|
@Rollervi97 update ? |
|
Sorry for the late reply, in this third push there should be all the modification requested. |
gautierhattenberger
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue on chirp input (integration of chirp signal when noise was not present). Modification of chirp input telemetry message structure (now it includes also the current chirp input value). Addition of two new system identification input signal: doublet and wave.