Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaperTrail.request.without_versioning #1065

Conversation

Projects
None yet
2 participants
@westonganger
Copy link
Contributor

commented Mar 15, 2018

This PR is related to Issue #916.

It adds the following methods:

PaperTrail.request.without_versioning do
end

PaperTrail.request.enabled_for_all_models?
PaperTrail.request.enabled_for_all_models(bool)
PaperTrail.request.enable_for_all_models
PaperTrail.request.disable_for_all_models
@jaredbeck

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

  1. enabled_for_all_models? seems redundant given we already have the (poorly named) enabled_for_controller?
  2. I don't want Request to have two different methods that take blocks. If possible, I'd like PaperTrail.request() do .. to be the only thing that takes a block.
@westonganger

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2018

  1. Yeah I was just following convention.
  2. Okay, I had a suggestion to this here in Issue #1064
@jaredbeck

This comment has been minimized.

Copy link
Member

commented Mar 24, 2018

Closing via #1069, thanks Weston for the ideas.

@jaredbeck jaredbeck closed this Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.