Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return values of record_* methods #1094

Conversation

Projects
None yet
2 participants
@westonganger
Copy link
Contributor

commented May 29, 2018

No description provided.

@jaredbeck

This comment has been minimized.

Copy link
Member

commented May 29, 2018

Can you please put a comment above these methods like "we return the created version so that paper_trail-associations_tracking can use it"? We don't want to accidentally break the return in the future.

@jaredbeck jaredbeck merged commit 745f0e0 into paper-trail-gem:remove_association_tracking May 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.