Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve associations section in Readme #1097

Conversation

Projects
None yet
2 participants
@westonganger
Copy link
Contributor

commented May 30, 2018

No description provided.

tracking was part of PT core until 2018 as an experimental feature and was use at your own risk. The gem now
maintains a list of known issues and we hope the community can help remove some of them via PR's.

In PaperTrail v10, the association tracking feature was extracted to a gem to simplify things in PaperTrail and

This comment has been minimized.

Copy link
@jaredbeck

jaredbeck May 30, 2018

Member

Since it's not a breaking change, I was thinking this could happen in 9.2.

This comment has been minimized.

Copy link
@westonganger

westonganger May 30, 2018

Author Contributor

Fair enough lets go with that then


A little history lesson, discussed as early as 2009, and first implemented in late 2014, association
tracking was part of PT core until 2018 as an experimental feature and was use at your own risk. The gem now
maintains a list of known issues and we hope the community can help remove some of them via PR's.

This comment has been minimized.

Copy link
@jaredbeck

jaredbeck May 30, 2018

Member

What was your goal with this paragraph? I think I prefer the existing version.

This comment has been minimized.

Copy link
@westonganger

westonganger May 30, 2018

Author Contributor

I think the tone has improved

This comment has been minimized.

Copy link
@jaredbeck

jaredbeck May 30, 2018

Member

I agree the existing version sounds a bit negative. I was trying to explain why the gem was extracted, that's why I had that negative-sounding focus on the list of known issues. Maybe we could go with what you have but also direct people to #1070 if they want to know why it happened?

This comment has been minimized.

Copy link
@westonganger

westonganger May 30, 2018

Author Contributor

Sure just write something up that you like. I mainly was concerned about the tone thats all.

`paper_trail-association_tracking` and keep running the existing tests related
to association tracking. This arrangement will be maintained for a few years, if
practical.
If you would like to track and reify associations you can utilize the following PT plugin: [paper_trail-association_tracking][6]

This comment has been minimized.

Copy link
@jaredbeck

jaredbeck May 30, 2018

Member

Good idea to start the section with a simple, introductory sentence and a link.

@jaredbeck

This comment has been minimized.

Copy link
Member

commented May 30, 2018

Closed via 72b3f2c, thanks.

@jaredbeck jaredbeck closed this May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.