Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: allow also actix-web 3.0 in addition to 2.0 (for v0.4.*) #218

Merged
merged 2 commits into from Sep 20, 2020
Merged

Deps: allow also actix-web 3.0 in addition to 2.0 (for v0.4.*) #218

merged 2 commits into from Sep 20, 2020

Conversation

strohel
Copy link
Contributor

@strohel strohel commented Sep 16, 2020

Actix 3.0 has been recently released. It seems that paperclip (v0.4.1)
builds just fine against both actix-web 2.0 and 3.0
(and their dependent libs).

So just relax the dependency and let downstream crates choose which major
version of actix they pull.

I've tested this with downstream crates requiring both actix 2.0 and crates requiring 3.0,
works wel. YMMV.

This change is based (in git sense) on v0.4.1 tag rather than current master. Current master seems to contain feature changes to be released as v0.5. It would be cool if actix 3.0 support can be released earlier as v0.4.2 (v0.2.2). If you'd create a branch out of v0.4.1 (or a some later commit still slated for "stable" 0.4 branch), I'll change target of this PR and it should apply cleanly.

@strohel
Copy link
Contributor Author

strohel commented Sep 16, 2020

This would obsolete #214, #215.

@wafflespeanut
Copy link
Collaborator

wafflespeanut commented Sep 20, 2020

This is great news! I think we can release 0.4.2 with the existing changes after merging this PR. Could you rebase it?

Actix 3.0 has been recently released. It seems that paperclip (v0.4.1)
builds just fine against both actix-web 2.0 and 3.0
(and their dependent libs).

So just relax the dependency and let downstream crates choose which major
version of actix they pull.

I've tested this with downstream crates requiring both actix 2.0 and 3.0,
works wel. YMMV.
@strohel
Copy link
Contributor Author

strohel commented Sep 20, 2020

I think we can release 0.4.2 with the existing changes after merging this PR. Could you rebase it?

Okay, I've rebased this on master. Note that current master contains (at least) one regression #216, and that versions are already bumped there (0.4 -> 0.5, 0.3 -> 0.4, 0.2 -> 0.3).

@strohel
Copy link
Contributor Author

strohel commented Sep 20, 2020

Note that current master contains (at least) one regression #216

...but I see this seems this already has a fix in @dunnock's repo: dunnock@178bf906 (that is part of 2 PR's here)

@wafflespeanut
Copy link
Collaborator

wafflespeanut commented Sep 20, 2020

I can change the versions back and do a minor bump instead. It was done only for convenience. There hasn't been any breaking changes so far.

@wafflespeanut wafflespeanut linked an issue Sep 20, 2020 that may be closed by this pull request
@wafflespeanut wafflespeanut self-requested a review Sep 20, 2020
@wafflespeanut wafflespeanut merged commit a4a02f0 into paperclip-rs:master Sep 20, 2020
1 check passed
@strohel
Copy link
Contributor Author

strohel commented Sep 20, 2020

Thanks!

@strohel strohel deleted the actix-web-3 branch Sep 20, 2020
@wafflespeanut
Copy link
Collaborator

wafflespeanut commented Sep 20, 2020

Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Actix-3
2 participants