Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bungee-plugin-message-channel" on true breaks custom BungeeCord plugin messaging #1312

Closed
kangarko opened this issue May 5, 2024 · 4 comments

Comments

@kangarko
Copy link

kangarko commented May 5, 2024

If a third party plugin writes on the BungeeCord channel with this option on true it never receives the plugin message packet.

This is caused by the method below returning true and not allowing subChannel to be customized by third party developers. This works just fine on BungeeCord which is superior to Velocity anyways. I am just kidding, please let developers use BungeeCord channel for their plugins.

@electronicboy
Copy link
Member

The bungeecord channel is not your channel, it's 100% intentional that we do not allow others to abuse this channel, use your own, or use the features within the channel properly.

@electronicboy electronicboy closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2024
@kangarko
Copy link
Author

kangarko commented May 5, 2024

Thanks for the info.

Afaik the BungeeCord channel cannot be spoofed by malicious clients so they can't write custom packets and execute commands on the network?

We used to broadcast plugin messages on the BungeeCord channel on Bungee for that reason.

@electronicboy
Copy link
Member

electronicboy commented May 5, 2024

Afaik the BungeeCord channel cannot be spoofed by malicious clients so they can't write custom packets and execute commands on the network?

That is why you validate the sender of the messages in the proxy plugin, there is no real justification for hijacking somebody else's channel here

@kangarko
Copy link
Author

kangarko commented May 6, 2024

Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants