Normalize ApplicationWindow setup #37

Closed
geiseri opened this Issue Dec 1, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@geiseri
Contributor

geiseri commented Dec 1, 2014

Right now there is very tight coupling between the ApplicationWindow, Toolbar, PageStack, Page and ActionBar. They reference items that may or may not be declared yet, and depending on how the application is started you can get hangs or null errors. Normally QML will want as much statically declared, and things that are dynamic are created via delegates or Loaders. The Page container has quite a few data elements (actions, tabs, transitions) that should really be exposed as models, and the PageStack uses delegates to render those models when they change. This will ensure everything is correctly set up before the bindings are hooked up.

I think the Page should really become an Object container with the actionbar, title and content properties. Then the PageStack would have a delegate that allows it to render the current item based on the index that is manipulated by push and pop..

@iBelieve iBelieve modified the milestone: Version 0.1 Dec 15, 2014

@iBelieve

This comment has been minimized.

Show comment
Hide comment
@iBelieve

iBelieve Apr 17, 2015

Member

We've come a long way since this was opened. We've migrated to using QtQuick.Controls, which has been a huge benefit for cleaning up the code. Most of the tight coupling should have been addressed. If there are any further concerns, please reopen this or open issues for specific things. Thanks!

Member

iBelieve commented Apr 17, 2015

We've come a long way since this was opened. We've migrated to using QtQuick.Controls, which has been a huge benefit for cleaning up the code. Most of the tight coupling should have been addressed. If there are any further concerns, please reopen this or open issues for specific things. Thanks!

@iBelieve iBelieve closed this Apr 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment