Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty result errors #71

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@Eggerd
Copy link
Contributor

Eggerd commented Oct 10, 2019

The query uses error id=1281 msg=database\sempty\sresult\sset to signal that there are no results to return - which makes sens for a text-based protocol. In PHP however, we have the option to simply return an actual empty value.

Some of the commands that may return an empty result error:

  • channelclientpermlist
  • channelgroupclientlist
  • clientdbfind
  • clientpermlist
  • complainlist
  • ftgetfilelist
  • ftlist
  • messagelist
  • privilegekeylist
  • servergroupclientlist
  • servergrouppermlist
  • servertemppasswordlist
  • tokenlist

So, ignoring the empty result error and returning an empty value would would benefit users, as they no longer have to check for this error themself whenever they use any of the commands listed above.

@par0noid par0noid self-assigned this Oct 11, 2019
@par0noid

This comment has been minimized.

Copy link
Owner

par0noid commented Oct 11, 2019

Thanks!

@par0noid par0noid merged commit 5d643e5 into par0noid:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.