i.actor.add is not a function ? #255

Open
tahma opened this Issue Oct 13, 2014 · 11 comments

Projects

None yet

10 participants

@tahma
tahma commented Oct 13, 2014

a lot of users have this problem
on debian stable and gnome 3.4.2
good to know that the v24 is working

@criess
criess commented Oct 25, 2014

Same problem exists for Centos 7 which uses gnome 3.8.4
So i guess rhel7 and it's clones are affected, too.

I extracted a trace from my gnome-session log

JS LOG: System monitor applet init from /home/criess/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com
JS LOG: System monitor applet enabling
JS LOG: Extension "system-monitor@paradoxxx.zero.gmail.com" had error: TypeError: i.actor.add is not a function
JS ERROR: !!!   Exception was: TypeError: this.tip_labels[i] is undefined
JS ERROR: !!!     message = '"this.tip_labels[i] is undefined"'
JS ERROR: !!!     fileName = '"/home/criess/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js"'
JS ERROR: !!!     lineNumber = '862'
JS ERROR: !!!     stack = '"()@/home/criess/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:862
wrapper()@/usr/share/gjs-1.0/lang.js:213

regards CR

@taringamberini

The extension system-monitor can't be executed as shown in the following screenshot

system-monitoy_error_screenshoot

The error Looking Galss shows is:

TypeError: i.actor.add is not a function

while the error logged in my ~/.xsession-errors is:

JS ERROR: !!!   Exception was: TypeError: this.tip_labels[i] is undefined
JS ERROR: !!!     message = '"this.tip_labels[i] is undefined"'
JS ERROR: !!!     fileName = '"/home/tarin/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js"'
JS ERROR: !!!     lineNumber = '862'
JS ERROR: !!!     stack = '"()@/home/tarin/.local/share/gnome-shell/extensions/system-monitor@paradoxxx.zero.gmail.com/extension.js:862
wrapper()@/usr/share/gjs-1.0/lang.js:204

My system details are:

  • Debian
    • Versione 7.7 (wheezy) 64 bit
    • Kernel Linux 3.2.0-4-amd64
    • Gnome 3.4.2
    • Iceweasel 31.2.0
  • Graphic Driver
    • X.Org X Server 1.12.4
    • AMD Catalyst™ 14.9 Proprietary Linux x86 Display Driver
  • Hardware
    • AMD FX(tm)-8350 Eight-Core Processor × 8
    • AMD Radeon R9 290X Graphics Card

Thanks,
Tarin

@zd3nik
zd3nik commented Nov 17, 2014

I'm on CentOS 7 and getting this error. tahma suggests that v24 works, so I tried it, but v24 doesn't even attempt to load. Alt+F2 -> lg -> Extensions -> Show Errors says: "Out of date". No errors in /var/log/messages. Is there a work-around to get v24 (or the latest version) working? I feel blind without this very awesome extension.

@esapelli
esapelli commented Dec 1, 2014

Same error on mine.

Lançamento 7.7 (wheezy) 32-bit
Kernel Linux 3.2.0-4-686-pae
GNOME 3.4.2
Intel® Pentium(R) M processor 1.73GHz

last version downloaded from git dont work either.

@blazeddigi
'i.actor.add' error can be fixed by editing lines 843, 845, & 848 of extension.js
Line Code
843 tipline.actor.add(new St.Label({ text: _(this.color_name[i]) }));
New tipline.actor.add_actor(new St.Label({ text: _(this.color_name[i]) }));
845 tipline.actor.add(this.tip_labels[i]);
New tipline.actor.add_actor(this.tip_labels[i]);
848 tipline.actor.add(this.tip_unit_labels[i]);
New tipline.actor.add_actor(this.tip_unit_labels[i]);
After correction, I encountered an [error on line 883: 'StatusArea.aggregateMenu' is not defined] which seems to be only a mislabeled function. this error does not appear in ~/.xsession_errors, only in looking glass.
(extension applet still not appearing in panel)

Debian 7.7 / Gnome 3.4

@p91paul
Contributor
p91paul commented Dec 10, 2014

might be a better idea to add something like the following at the beginning

if (!tipline.actor.add)
    tipline.actor.add = tipline.actor.add_actor;

Which would fix errors and also avoid to break compatibility with later versions.

If you manage to put together a complete fix, you might well fork the repository and open a pull request.

@brunetton
Contributor

Same problem here. Works with version 29. But i don't know howto match SweetTooth v29 with git repo commit hash, so I can't really help here.

@jhaiduce
jhaiduce commented Jan 7, 2015

Same problem on RHEL 7 (although this is expected since it was already reported for CentOS 7)

@brunetton
Contributor

Workaround found !

I found the breaking commit, using git bisect. So to make extension works with Debian Wheezy, follow the manual install and reset git repo to the last good knonw commit :

cd [your_git_repos]/gnome-shell-system-monitor-applet
git reset --hard cc86a2825185a

Then restart gnome-shell (Alt + F2, r, Enter)

(of course, this is not a solution, only a workaround waiting for the bug to be fixed)

@jhaiduce
jhaiduce commented Feb 9, 2015

The workaround suggested by brunetton works for me on RHEL 7.

@ezerusso

It did work for me too, at Centos 7 x64. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment