Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] persistant set to true for basic example #6

Closed
NabiKAZ opened this issue May 24, 2020 · 5 comments
Closed

[Bug] persistant set to true for basic example #6

NabiKAZ opened this issue May 24, 2020 · 5 comments

Comments

@NabiKAZ
Copy link
Contributor

NabiKAZ commented May 24, 2020

I see in the basic example, the persistant param must be true about echo.websocket.org sample server for works it.

if( $sp = websocket_open($server, 80,'',$errstr) ) {

@NabiKAZ
Copy link
Contributor Author

NabiKAZ commented May 24, 2020

I created a PR #7

@NabiKAZ NabiKAZ changed the title persistant set to true for basic example [Bug] persistant set to true for basic example May 24, 2020
@paragi paragi closed this as completed May 24, 2020
@paragi
Copy link
Owner

paragi commented May 24, 2020

Thanks for your contribution. It is appreciated.

@NabiKAZ
Copy link
Contributor Author

NabiKAZ commented May 24, 2020

@paragi
About latest commit: 2701bd6#diff-4ca99799013cf187846f3e325110c2f3L7
I see you come back changed persistant param of example to false and it don't works for echo.websocket.org server.
Please test the example again.

@paragi
Copy link
Owner

paragi commented May 24, 2020

I get this:

$ php example.php 

Connecting to server: echo.websocket.org 
Sending message to server: 'hello server' 
Server responed with: 'hello server'

What do you get?
(know that there was a bug in a previous PR, that I just fixed)

@NabiKAZ
Copy link
Contributor Author

NabiKAZ commented May 24, 2020

Yes, that's works for now.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants