Don't recalculate hash if it exists and file is unmodified #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 752
💛 - Coveralls |
larowlan
force-pushed
the
read-only-hash-static
branch
from
5a0f622
to
72d226c
Compare
peter279k
reviewed
Aug 27, 2019
| if ($this->hash) { | ||
| $this->toctouTest(); | ||
| return $this->hash; | ||
| } |
There was a problem hiding this comment.
Could you write some tests about these changes?
There was a problem hiding this comment.
There are existing tests that call getHash()
There was a problem hiding this comment.
Ok. I see that. Thanks for your reply/explanation :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139