Update addhtml to handle bigger content

[Uzlopak]

Example:

const doc = jsPDF()
    doc.addHTML(document.getElementById('toHTML'), 10, 10, {pagesplit: true, margin: {top: 10, right: 10, bottom: 10, left: 10, useFor: 'page'}}, function () {doc.save("test.pdf")})

const doc = jsPDF()
   doc.addHTML(document.getElementById('toHTML'), 10, 10, {pagesplit: true, margin: {top: 10, right: 10, bottom: 10, left: 10, useFor: 'content'}}, function () {doc.save("test.pdf")})

[MrRio]

Seems to be the tests on IE11 that aren't having a good time

[Uzlopak]

I realized my master-branch is tainted with a changed standardfontmetrics.js

[Uzlopak]

Well reverting the file standardfontmetrix.js fixed it. :)

I wrote this PR to close some open issues and because some people still use this plugin and ask for margins....

[MrRio]

Thanks very much for this PR. I’ll get it reviewed and merged :-)

[hrc7505]

I have used this

const doc = jsPDF()
    doc.addHTML(document.getElementById('toHTML'), 10, 10, {pagesplit: true, margin: {top: 10, right: 10, bottom: 10, left: 10, useFor: 'page'}}, function () {doc.save("test.pdf")})

but still my pdf look like this

[Uzlopak]

Did you applied the necessary changes?
https://github.com/MrRio/jsPDF/pull/1450/files

[hrc7505]

I have installed jsPDF by using npm i jspdf --save.
so inside node_modules->jspdf there are only two js files,

1. jspdf.debug.js
2. jspdf.min.js

No other libraries are there.
So how can I put these changes to that.
And I have also used following to js files from latest master.
1). html2pdf.js
2). html2canvas.js

Still I don't have any other js for support.
Do I need to link those js files of your latest master to my project?
How can I put these changes to my project?

[Uzlopak]

if you don't apply the changes from the pull request then you can't expect that it will work. Please inform yourself what a Pullrequest is.

[Uzlopak]

https://help.github.com/articles/about-pull-requests/

[ghost]

I applied all the changes in your PR but I'm getting an error.
The error is:
Uncaught TypeError: Cannot read property 'apply' of undefined at line 132 of addhtml.js

I'm using the latest master release and I included jspdf.js, addhtml.js, from_html.js, split_text_to_size.js, standard_fonts_metrics.js, html2canvas.js

[Uzlopak]

Line 132 is

this.addImage.apply(this, args);

So probably you should add addImage Plugin...

[hrc7505]

Thank you arasabbasi. I applied the changes on the given link https://github.com/MrRio/jsPDF/pull/1450/files and it works.

[Uzlopak]

Thank you for your feedback

[FaiyazMdAbdul]

Hi ..

• I cloned the latest master.
• did npm install
• npm start
• Tested this example http://localhost:8000/examples/html2pdf/showcase_supported_html.html by adding this script
  const doc = jsPDF() doc.addHTML(document.body, 10, 10, {pagesplit: true, margin: {top: 10, right: 10, bottom: 10, left: 10, useFor: 'page'}}, function () {doc.save("test.pdf")}) .

but I am getting blank screen.

*Since this commit is merged into master, I haven`t edited the changes mentioned in updated files .

where am i going wrong?

[yasirrafiq33]

LGTM

[yasirrafiq33]

LGTM

[yasirrafiq33]

https://github.com/MrRio/jsPDF/pull/1450/files

How can I merge this pull request to my code?
Please help ASAP.

[philharmonie]

This is merged to the master, right? I don't see any margins. Am I'm doing something wrong?
`var doc = new jsPDF('p','mm','a4');

	var margins = {top: 90, bottom: 60, left: 90, width: 900};

	doc.internal.scaleFactor = 6;
	doc.addHTML(document.body, margins, function() {
			doc.save("test.pdf");
	});
}`

[Uzlopak]

@philharmonie
Please open an issue.