Community Projects

[PropGit]

Shouldn't Community Projects only show projects that are shared to the community? ie: everyone, regardless of their logged-in status, should see the same list of projects?

Instead, Community Projects shows shared projects (from every user), and if you're logged in, also includes private projects owned by the logged-in user.

I don't think it should ever show private projects on the Community Page.

[PropGit]

Addendum... if we need to show a logged-in user's content (regardless of private/shared status) then it'd be best that it decorates the row somehow to indicate that it's your own, private, project. That still really doesn't fit with the concept of "Community Projects," though, so I don't think it's best to do so.

[MatzElectronics]

This should simple be an addition to the SQL: AND mine != true...

[zfi]

Let's solidify the definition of private vs. community projects. The project table in the database actually has flags for shared and private. Currently, we rely on logic at the dao layer to ensure that these flags remain mutually exclusive.

Community projects are those projects where the 'shared' flag is true.
Private projects are those projects where the 'private' flag is true.

[MatzElectronics]

Not sure why there are two separate flags... could we pick one (say "private") and use it as the sole check? *Matthew Matz | STEM/Robotics Educator* Parallax Inc. | Direct: 916-625-3019 | www.parallax.com | @m atzElectronics <http://twitter.com/MatzElectronics> | Licenses <http://www.tspc.oregon.gov/lookup_application/LDisplay_Individual.asp?id=07080L3B270>

…

On Tue, Jun 19, 2018 at 5:32 PM, Jim Ewald ***@***.***> wrote: Let's solidify the definition of private vs. community projects. The project table in the database actually has flags for shared and private. Currently, we rely on logic at the dao layer to ensure that these flags remain mutually exclusive. Community projects are those projects where the 'shared' flag is true. Private projects are those projects where the 'private' flag is true. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1365 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AS0quH7GCA9qMs9ZDJ-8bMZqaXSCBWN3ks5t-ZgfgaJpZM4RlFK7> .

[zfi]

I can refactor the code to use the 'private' field, since that was the defined before the 'shared' field. I believe that the shared field was a first attempt to support the project link feature. I will open a new issue for the refactor.

[PropGit]

Verified fixed.