Syntax check shortcut and highlight syntax errors #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/stores/editor.js
Outdated
phated
added a commit
that referenced
this pull request
Jul 2, 2015
Syntax check shortcut and highlight syntax errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This PR adds a syntax check feature that tokenizes the current source and reports any issues, highlighting the reported line. Syntax check is bound to Ctrl+T and F7.
Where should the reviewer start?
Run a syntax check on any source code, if successful an green success toast should appear. Introduce an error by misnaming a function or adding an invalid unicode character, when syntax check runs it should display the failure toast and highlight the code.
What are the relevant tickets?
Closes /issues/129
Closes /issues/132