-
Notifications
You must be signed in to change notification settings - Fork 10
Major performance improvements in console and TX/RX flash #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A simple fast-debug-loop: |
…op before exhausting console
plugins/editor/scroller.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be function Scroller(){ so you don't have an anonymous class
…sole is registered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ints here are just shortcuts to px styles, but this is fine
Major performance improvements in console and TX/RX flash
What's this PR do?
This PR fixes two major performance hits when running a program that has very fast debug output. The first is to simplify the RX/TX flashes to avoid triggering expensive React changes. The second is to rework console output updating to avoid expensive scroll operations and has the additional benefit of allowing smooth scrollback even as more data comes in.
What are the important parts of the code?
The
scroller.jsclass in the editor plugin contains the receive pane update logic which controls the majority of the scrolling logic. Theindicators.jsclass contains the new RX/TX logic.How should this be tested by the reviewer?
Run a fast-loop debug program at various speeds, try to scroll back the window and see how it functions. Verify the window will re-enter 'sticky' mode when scrolled to the bottom of the screen.
Is any other information necessary to understand this?
This fixes a major performance issue on older chromebook devices by reducing the redraw/scroll events within the receive pane.
What are the relevant tickets? (Please add
closes,refs, etc)Closes #178