New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing SFTP.rename with SFTP.posix_rename in 3.0 #1016

Closed
bitprophet opened this Issue Jul 13, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@bitprophet
Member

bitprophet commented Jul 13, 2017

As per #1012 it's easy for folks caring about the details to get confused by the current, legacy behavior of SFTP file renaming. One way to solve this is for us to declare the old behavior to be bad/incorrect, and to just nuke it in favor of the 'POSIX' style rename in a major release.

I'd still like to know more about the differences & see if there's any info on why the 'non-POSIX' behavior was initially added (my guess is that it's just a naive first implementation, but dunno) but that's mostly a sanity check.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Jul 13, 2017

Pro tip, maybe leave ticket triage for later in the day...clearly not awake enough not to miss stuff.

We added posix_rename in 2.2, via #65 / #471 and from those tickets it's clear that the deal is the "posix rename" is an extension to the protocol implemented by OpenSSH specifically. Following from this is the assumption that other SSH/SFTP servers may well not implement this extension.

So this feels like it should just be a documentation-only "fix" (which was going to be another ticket, but now, no point) to try and help folks like the submitter of #1012 notice quicker that the behavior they are seeking does exist.

@bitprophet bitprophet modified the milestones: Next bugfix, 3.0 Jul 13, 2017

bitprophet added a commit that referenced this issue Jul 13, 2017

dkhapun pushed a commit to cyberx-labs/paramiko that referenced this issue Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment