Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update documentation with non-optional dependencies #1191
On the installation page at paramiko.org it says:
...but in setup.py:
...which was a bit of a surprise!
Could the docs be updated, please?
This is one reason I don't even like installation docs
Thanks for noticing! My initial reaction was "well those are probably just pinned Cryptography sub-dependencies" but no, they are just similar. (eg
Notes to self...
Bcrypt and PyNaCl are required for Ed25519 support, so that's a straight addition.
PyASN1 is currently only needed for optional GSSAPI support, so aside from import-level shenanigans, I don't get why we added it to our top level requires...
Dug and it seems like we used it for Cryptography-1.1 based DSS, etc keys partway through development of that switch-over - but then it was removed again in eb3e117 without also removing it from setup.py?
Going to poke a bit around 2.2.x and see if I can convince things to install and test w/o pyasn1 installed (GSSAPI is an optional test suite as well) and then I'll patch up setup + docs and merge-up.
Pondering whether we can/should remove
Think I'll just make the changes on master for now?
Seems all right, updated the pyasn1 imports in the gssapi module (
So, Paramiko 2.5.x, when it comes out, will have this change in its code, and the docs will have the change as soon as I push. Thanks again!