Join GitHub today
Backport a version-agnostic form of crypto 1.5 compatibility #1292
Increasingly vexed by the enormous reams of warnings spat out by Paramiko <2.3 during test runs, caused by a lack of #979.
However, it's not nice to backport that ticket itself (because then dependencies will change in tertiary releases - I'm more flexible these days but that's beyond the pale) so I want to see if it's feasible to rewrite it for 2.0+ in a "if X else Y" fashion.
Ought to be straightforward? Famous last words...
Remember to make sure that the merge from 2.2 to 2.3 uses
Belatedly realized a side effect of this is that 2.3+ could ostensibly relax its version requirement for Cryptography if we preserve the either-or code during the merge.
However that cat's out of the bag - users of Paramiko 2.3+ are already going to be on Cryptography 1.5+ - so it doesn't really seem worthwhile. And esp re: crypto libraries we want to be pushing users to get used to updating periodically instead of staying on old versions, when we have a choice...
FWIW I am unable to even return to older cryptography versions on macOS 10.12, so I'm basically relying on Travis here (tho I can test on a container locally if I gotta).
Also of note, I'm very slightly modifying the logic in the code, pulling the setup of the signatures/etc inside the