New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix win_pageant for Python 3 #320
Conversation
👍, works fine on Python 3.4 |
Previously _get_pageant_window_object always returned 0, so pageant was silently ignored.
+1 This is a fix for me too. Tested with 1.15.1 Not sure how this will affect a python2.6 install though. |
I don't Python on Windows but yea, we still need to support Python 2.6 (@adamkerz). Should hopefully be as simple as importing the relevant bits from I'll merge this once somebody can +1 a version of the patch that works on 2.6 through 3.4. Thanks! |
Ugh, why do people still use and/or care about 2.6? Especially on windows where there are no "enterprisey" distributions forcing you to use ancient versions? |
@ThiefMaster There are still plenty of people downloading Python packages on 2.6 according to stats I've seen from PyPI, and a number of stable Linux distributions still in heavy use like CentOS 5/6 also still use them. It's also very little extra work re: 2+3 support, over 2.7. |
OK, tested with Python 2.6.6, 2.7.6 and 3.4.1. Patch against Paramiko 1.15.1. Hmm, am I able to upload a patch here? Or do I need to do the GIT push/pull thing (I'm not a GIT user yet)? |
It would be preferable to do a pull request. But if you just have the diff of your changes you can add them as a comment. |
OK, in the interest of getting this in, I'll comment the diff. I have a feature to add to fabric (user/group for the put operation) that I will use as a task to get my self "git" sorted.
Thanks for accepting it in a less desirable way! |
Created a real PR from the patch. |
Rolling into that PR, thanks as usual @lndbrg! |
This fixes paramiko#320 (thanks @adamkerz).
Previously _get_pageant_window_object always returned 0, so pageant was silently ignored.