NameError: global name 'descriptor' is not defined #461
Comments
Please fix it and update version. |
I'd love to see unittests for this kind of stuff... Also, using a decent IDE would show you that error immediately ;) |
You are not seeing mistake in method "descriptor"? Variable "descriptor" does not exists in global namespace. There are simple things for which UnitTests are not necessary. |
Yes I do see the mistake. My comment was more directed to the paramiko devs than you. Having unit tests for e.g. the pageant integration would avoid such errors ending up in a release (same for the python3 issue related to bytestrings/unicode in the pageant interface of the previous version) |
I agree with You :) |
This is an open source product and you are always free to submit pull requests for improvements. |
There is currently CI that should catch this kind of error and ensure compatibility with python2.6 - 3.4 |
Maybe this error is happening in Windows only. Your CI is working in linux. |
Unfortunately, Windows support is strictly on a user-driven basis as neither the developers' local platforms, nor the CI platform (Travis) support Windows. We'll usually merge pull requests that have multiple +1s from Windows users, & which are proven not to break POSIX platforms :) |
Why this discussion, if there is an elementary error in the code that can be corrected in 5 seconds? |
+1 |
2 similar comments
+1 |
+1 |
@liminspace because talk is cheap XD |
+1 |
Merging this with #469 |
There is error if use in windows.
File _winapi.py:220
Maybe must be so:
The text was updated successfully, but these errors were encountered: