Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.16 sftp_file prefetch not backward compatible #676

Closed
stevevanhooser opened this issue Feb 3, 2016 · 2 comments
Closed

version 1.16 sftp_file prefetch not backward compatible #676

stevevanhooser opened this issue Feb 3, 2016 · 2 comments

Comments

@stevevanhooser
Copy link

@stevevanhooser stevevanhooser commented Feb 3, 2016

Bug: In version 1.16 of paramiko, the function in sftp_file.py called "prefetch" now requires 2 input arguments (self and the file_size to be read in). In previous libraries it assumed that the entire file was going to be read in and the second argument was not present.

This causes older software (such as bzr) that only pass one input argument to fail.

I am working to patch the code so that if only 1 input argument is given, the code will default to the whole file, which is the legacy behavior.

@stevevanhooser stevevanhooser changed the title version 1.16 sftp_file prefresh not backward compatible version 1.16 sftp_file prefetch not backward compatible Feb 3, 2016
@stevevanhooser
Copy link
Author

@stevevanhooser stevevanhooser commented Feb 4, 2016

This is now posted as pull #677

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 25, 2016

Rolling into the PR.

@bitprophet bitprophet closed this Apr 25, 2016
bitprophet added a commit that referenced this issue Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants