Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_to_file shall use filemode "append", not "write" #683

Closed
vlcinsky opened this issue Feb 8, 2016 · 5 comments
Closed

log_to_file shall use filemode "append", not "write" #683

vlcinsky opened this issue Feb 8, 2016 · 5 comments

Comments

@vlcinsky
Copy link

@vlcinsky vlcinsky commented Feb 8, 2016

See StackOverflow question

Paramiko log files created by means of paramiko.util.log_to_file("filename.log') result always in overwriting the previous logs.

The reason is clear, the util.py line 24 is opening the file with "w" mode.

Consider changing to "a".

@sunjeewa
Copy link

@sunjeewa sunjeewa commented Sep 20, 2016

+1

Loading

2 similar comments
@vicosoft
Copy link

@vicosoft vicosoft commented Nov 30, 2016

+1

Loading

@PurplePinkie
Copy link

@PurplePinkie PurplePinkie commented Feb 23, 2017

+1

Loading

ploxiln added a commit to ploxiln/paramiko-ng that referenced this issue Feb 23, 2017
bitprophet added a commit that referenced this issue Feb 23, 2017
bitprophet added a commit that referenced this issue Feb 23, 2017
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Feb 23, 2017

Fixed via #907

Loading

@bitprophet bitprophet closed this Feb 23, 2017
@PurplePinkie
Copy link

@PurplePinkie PurplePinkie commented Feb 23, 2017

very nice. tnx! ;-)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants