Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_to_file shall use filemode "append", not "write" #683

Closed
vlcinsky opened this Issue Feb 8, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@vlcinsky
Copy link

vlcinsky commented Feb 8, 2016

See StackOverflow question

Paramiko log files created by means of paramiko.util.log_to_file("filename.log') result always in overwriting the previous logs.

The reason is clear, the util.py line 24 is opening the file with "w" mode.

Consider changing to "a".

@sunjeewa

This comment has been minimized.

Copy link

sunjeewa commented Sep 20, 2016

+1

2 similar comments
@vicosoft

This comment has been minimized.

Copy link

vicosoft commented Nov 30, 2016

+1

@PurplePinkie

This comment has been minimized.

Copy link

PurplePinkie commented Feb 23, 2017

+1

ploxiln added a commit to ploxiln/paramiko that referenced this issue Feb 23, 2017

bitprophet added a commit that referenced this issue Feb 23, 2017

bitprophet added a commit that referenced this issue Feb 23, 2017

@bitprophet

This comment has been minimized.

Copy link
Member

bitprophet commented Feb 23, 2017

Fixed via #907

@bitprophet bitprophet closed this Feb 23, 2017

@PurplePinkie

This comment has been minimized.

Copy link

PurplePinkie commented Feb 23, 2017

very nice. tnx! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.