Fix portability of test execution PacketizerTest.test_closed_3 #862
Comments
sbz
added a commit
to sbz/paramiko
that referenced
this issue
Dec 14, 2016
…TIME is not defined This changes define the proper Timer expired error message instead of raising AttributeError when errno.ETIME is not available on the platform. fixes paramiko#862
Thanks for the detailed report, let's just roll this into the PR ticket. |
bitprophet
added a commit
that referenced
this issue
Feb 20, 2017
…TIME is not defined This changes define the proper Timer expired error message instead of raising AttributeError when errno.ETIME is not available on the platform. fixes #862
bitprophet
added a commit
that referenced
this issue
Feb 20, 2017
…TIME is not defined This changes define the proper Timer expired error message instead of raising AttributeError when errno.ETIME is not available on the platform. fixes #862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some platforms where Python doesn't defined the errno.ETIME, it results the execution of test PacketizerTest.test_closed_3 to raise an AttributeError because of the call
os.sterror(errno.ETIME)
in file tests/test_packetizer.py#L119As FreeBSD maintainer, I included a local fix into our ports and I would like to upstream this fix because it could also impact others platforms. I will submit a PR for that.
Ansible developers did similar fix here
I think it's better to not enforce the value of the message because Linux, OSX and al differs on ETIME definition.
After fixing all tests are completed successfully using make test :
The text was updated successfully, but these errors were encountered: