LOL @ adding features in a bugfix release 😞 That kwarg seems to have been added at the same time as the warnings it mutes, going by their changelog on PyPI. Unfortunately this means if we just axe it, users will presumably get annoying warnings on bcrypt 3.1.3+.
Requiring users to be on bcrypt 3.1.3 or newer doesn't seem super awful to me (esp given it's a brand new requirement as of Paramiko 2.2.0). Otherwise we have to do something mildly gross like a try / except TypeError fallback to the non-ignore_few_rounds invocation of kdf(). Which then could mask real TypeErrors lower down.
So I'm thinking we just bump the setup.py requirement for bcrypt up to 3.1.3. If there are no counterarguments I'll do that soon.
Earlier versions don't support
That was with 3.1.2.
The text was updated successfully, but these errors were encountered: