Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Support pre-authentication banners #1013

merged 1 commit into from Sep 6, 2017


Copy link

@seveas seveas commented Jul 5, 2017

In the same project that caused me to file #946, I now need to send pre-authentication banners. Wasn't too hard to implement and I think it may be useful for others, hence another pull request :)

The ssh protocol allows for the server to send a pre-authentication
banner. It may be sent any time between the start of authentication and
successful authentication. This commit allow ServerInterface subclasses
to define messages which we'll send right right at the start of
authentication before we send the supported authentication methods.
Copy link

@ploxiln ploxiln commented Jul 6, 2017

looks clean and small 👍

Copy link

@bitprophet bitprophet commented Jul 6, 2017

Some tests would be rad but otherwise looks good, thanks!

@bitprophet bitprophet added this to the 2.3.0 milestone Jul 6, 2017
@bitprophet bitprophet merged commit bd807ad into paramiko:master Sep 6, 2017
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 44.44% of diff hit (target 75.25%)
codecov/project 75.2% (-0.06%) compared to 842caba
continuous-integration/travis-ci/pr The Travis CI build passed
bitprophet added a commit that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants