New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_pty named argument to SSHClient.exec_command() #115

Merged
merged 1 commit into from Feb 3, 2013

Conversation

Projects
None yet
2 participants
@mvanderkolff
Contributor

mvanderkolff commented Nov 30, 2012

Reason to do this is that saying:
sshCli = SSHClient()
sshCli.connect(....)
stdin,stdout,stderr = sshCli.exec_command("daemon_in_foreground",get_pty=True)
stdin.write('\x03') #^C
stdin.flush()

ends up killing the process as expected.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 3, 2013

Sure; e.g. Fabric does this too (it uses Channel.exec_command directly, and beforehand, optionally uses Channel.get_pty as this patch does) for similar reasons. This will be useful for folks using this method call directly.

Thanks!

bitprophet added a commit that referenced this pull request Feb 3, 2013

Merge pull request #115 from mvanderkolff/master
Add get_pty named argument to SSHClient.exec_command()

@bitprophet bitprophet merged commit 6b5d748 into paramiko:master Feb 3, 2013

1 check passed

default The Travis build passed
Details

bitprophet added a commit that referenced this pull request Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment