New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ed25519Key to __all__ #1168

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
3 participants
@patriksevallius
Contributor

patriksevallius commented Feb 21, 2018

PyCharm complains when I try to do:

from paramiko import Ed25519Key

It says Ed25519Key is missing from all.

This patch adds it to all and then PyCharm stops complaining.

@ploxiln

This comment has been minimized.

Contributor

ploxiln commented Feb 21, 2018

Yup, looks like it should be added there. Also, ECDSAKey seems to be in the same boat.

@patriksevallius

This comment has been minimized.

Contributor

patriksevallius commented Feb 21, 2018

Do you want me to add ECDSAKey to my branch and create a new PR?

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 22, 2018

Gah I hate __all__ sometimes. Suspect it gets overlooked because using from module import * is an antipattern anyways...guess some stuff like IDEs uses it as a hint guide? Or are we simply not importing it into __init__.py?

I'll add ECSDAKey when I merge, sec.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 22, 2018

Yea pycharm must be specifically introspecting __all__, we were importing those names prior to this PR. Bleh.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 22, 2018

OK there's even tests for this in tests/test_util.py, they just don't get updated apparently? Think that all predates me. EDIT: but I've got updates to that stuff in my auth shakeup branch, so, leaving alone for now / updating that copy.

@bitprophet bitprophet merged commit 01d3abb into paramiko:master Feb 22, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

bitprophet added a commit that referenced this pull request Feb 22, 2018

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 22, 2018

Thanks both!

@patriksevallius patriksevallius deleted the patriksevallius:add-ed25519key-to-all branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment