Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type converting config #1212

Merged
merged 4 commits into from Jun 14, 2018
Merged

Conversation

@offbyone
Copy link
Contributor

@offbyone offbyone commented May 16, 2018

In order to implement fabric/fabric#1753 I'm adding a configuration helper into paramiko to make it more reasonable to get config values in mapped types (yes -> True &c)

as_bool(key) and as_int(key) for the current raw string values in
SSHConfig"""

def __init__(self, *args, **kwargs):

This comment has been minimized.

@bitprophet

bitprophet May 16, 2018
Member

Do we still need this now that we're subclassing just dict and not UserDict?

This comment has been minimized.

@offbyone

offbyone May 16, 2018
Author Contributor

Good question. Probably not, but it doesn't hurt.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented May 16, 2018

  • When you have a sec, please try rebasing or merging onto latest master, which should get rid of all the incidentals in dev-reqs.txt etc.
  • Left a line note re: dunder-init, see above
  • Can you cave to my unreasonable formatting demands and make your docstrings of this format?
    """
    hello yes this is text
    """
    
@offbyone offbyone force-pushed the offbyone:add-type-converting-config branch from 35fca8f to 54384b3 May 16, 2018
@bitprophet bitprophet merged commit 54384b3 into paramiko:master Jun 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants