Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue where SSH daemon does not answer SSH_MSG_CHANNEL_REQUEST for "window-change" #133

Closed
wants to merge 1 commit into from

Conversation

@pheller
Copy link
Contributor

@pheller pheller commented Jan 17, 2013

resize_pty(), and Client.invoke_shell(). Perhaps useless, but more RFC
compliant. Updated methods to include these parameters in server messages.

Adjusted Channel.resize_pty() to neither request nor wait for a response, as
per RFC 4254 6.7 (A response SHOULD NOT be sent to this message.) This is
necessary as certain hosts have been observed to not acknowledge this type of
channel request (Cisco IOS XR), which causes paramiko to end the session.

resize_pty(), and Client.invoke_shell().  Perhaps useless, but more RFC
compliant.  Updated methods to include these parameters in server messages.

Adjusted Channel.resize_pty() to neither request nor wait for a response, as
per RFC 4254 6.7 (A response SHOULD NOT be sent to this message.)  This is
necessary as certain hosts have been observed to not acknowledge this type of
channel request (Cisco IOS XR), which causes paramiko to end the session.
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Feb 3, 2013

Looks good overall; have you confirmed this doesn't cause any actual issues on Linux/etc (i.e. non Cisco appliance) targets regarding window change events?

@pheller
Copy link
Contributor Author

@pheller pheller commented Feb 3, 2013

I have not, though I can give a quick test tomorrow against a few different targets (Juniper, Mac OS X, Linux).

I'll report back once I have conclusive results.

Regards,

--phil

On Feb 3, 2013, at 3:26 PM, Jeff Forcier notifications@github.com wrote:

Looks good overall; have you confirmed this doesn't cause any actual issues on Linux/etc (i.e. non Cisco appliance) targets regarding window change events?


Reply to this email directly or view it on GitHub.

@pheller
Copy link
Contributor Author

@pheller pheller commented Feb 8, 2013

Successful:
Verified with "stty -a":

  • Fedora 17 - OpenSSH_5.9p1, OpenSSL 1.0.0j-fips 10 May 2012
  • Mac OS 10.8.2 - OpenSSH_5.9p1, OpenSSL 0.9.8r 8 Feb 2011
  • Centos 4.9 - OpenSSH_3.9p1, OpenSSL 0.9.7a Feb 19 2003

Verified with "show cli":

  • JunOS 12.1R1.9 - OpenSSH_5.9, OpenSSL 0.9.8t 18 Jan 2012

Verified with "show term"

  • Cisco IOS XR 4.0.3
  • Cisco ACSW 5.2.0

Unsuccessful:
This host was unsuccessful (looking at "show term"), though it was also unsuccessful when connecting via SSH binary directly (OpenSSH_5.9p1, OpenSSL 0.9.8r 8 Feb 2011).

  • Cisco IOS 12.4(25d)

I think this testing reasonably confirms expected operation.

bitprophet added a commit that referenced this pull request Mar 1, 2013
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Mar 1, 2013

Github, I merged this, y u no mark closed :(

@bitprophet bitprophet closed this Mar 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants